[PHP-DEV] Don't compress empty output with zlib

[Edward Z. Yang]

Hello all, I've cooked up a short patch for Bug 42362, and would
appreciate comments. The patch turns off zlib compression if there is no
output, to make zlib_compression play more nicely with 304s.

Cheers,
Edward

Index: ext/zlib/zlib.c
===================================================================
RCS file: /repository/php-src/ext/zlib/zlib.c,v
retrieving revision 1.183.2.6.2.8
diff -u -r1.183.2.6.2.8 zlib.c
--- ext/zlib/zlib.c     31 Dec 2008 11:17:47 -0000      1.183.2.6.2.8
+++ ext/zlib/zlib.c     17 Feb 2009 20:43:28 -0000
@@ -979,7 +979,7 @@
 {
        zend_bool do_start, do_end;

-       if (!ZLIBG(output_compression)) {
+       if (!ZLIBG(output_compression) || !output_len) {
                *handled_output = NULL;
        } else {
                do_start = (mode & PHP_OUTPUT_HANDLER_START ? 1 : 0);


-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php