On Fri, Mar 12, 2010 at 9:52 PM, Pierre Joye <pierre....@gmail.com> wrote
> On Sat, Mar 13, 2010 at 12:27 AM, Stanislav Malyshev <s...@zend.com> wrote:
>> Hi!
>> It is possible, but that means instead of 2 trees of files you'd have these
>> trees distributed inside test files in a myriad of small if()s:
>> if(version == X) { test this error message }
>> elseif(version == Y) { test that error message }
>> else { test that another error message }
>>
>> and the same for different pieces of function, etc. Why is it better?
>
> I'm not saying it is better to write test, but it is better to
> maintain one set of tests for all branches and keep them uptodate. But
> that's definitivelly more work, and not only for the 1st shot. That's
> why I would rather triple check if we really want to go down this way.
One thing to notice is change in output between versions.
During testfest we wrote various tests and tried to make them as
generic as possible to run in 5.2/5.3/6.
It worked in mosts tests but some suttle differences would make it a
pain to write a unified test.
For example: When writing the tests for trunk "string" became "unicode"
Whatever path PHP6 does go down, we need to rememebr small changes
like this can come along in other aspects
So just a version check for the test is not all that's needed, we need
something to deal with these differences as well.
--
Rafael Dohms
PHP Evangelist and Community Leader
http://www.rafaeldohms.com.br
http://www.phpsp.org.br
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
