On Wed, Apr 3, 2013 at 2:00 PM, Stas Malyshev <smalys...@sugarcrm.com> wrote: > Hi! > >> There is absolutely no need for a RFC for it. >> Heck, even that initial curtesy mail was more then I would have expected. > > Agree, no need for full scale RFC for one constant. However, sending an > email to the list and actually waiting for feedback is exactly what I > would expect, especially dealing with stable version and feature that it > is not exactly clear what's going on with it. We're not talking about > writing RFCs for every minor change, we're talking about teamwork and > have members of the team be aware of the change and have time to discuss > it if needed. Nothing bad would happen if the same commit would land a > week later, after everybody is behind it and every detail is hashed out > (or not if turns out it is out of consensus). The point here is not to > impede work but to support teamwork.
There is a thin line between impeding work and team work for such a trivial change. This constant is actually really useful. The entire feature is however unfortunately broken, but had it been in a working shape then common. Really? Send an email and wait a week before being able to write a testcase? Anyway. Lets move on. I suspect removing an experimental feature in an extension that is disabled by default and requires external library still requires an RFC? And according to the current rules of the game it cannot be removed in 5.5.1, but has to be removed in 5.6.0? -Hannes -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
