Hey: On Sat, Jan 17, 2015 at 11:54 AM, Stanislav Malyshev <smalys...@gmail.com> wrote: > Hi! > >> you could fix it by change the output(it must because equal elements >> compare)... > > I could but I'd be busy for this weekend so it'd be better if you fixed > it since your patch broke it :) okey, I just don't have a env to reproduce it.. > Also it would be nice if such big changes were run through the CI before > committing. We have it run automatically with pull requests and also if > you don't want to do a pull you can connect Travis to your own fork so > that it would run the tests once you push it to your branch. thanks, this is really helpful.
> > Having CI in the red for a long time is not good since it allows other > bugs to creep in and prevents proper evaluation of pulls. In fact, we > have RFC about that: https://wiki.php.net/rfc/travis_ci > > -- > Stas Malyshev > smalys...@gmail.com -- Xinchen Hui @Laruence http://www.laruence.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
