Hi Dan, On Fri, February 6, 2015 17:16, Dan Ackroyd wrote: > On 5 February 2015 at 22:28, Rasmus Lerdorf <ras...@lerdorf.com> wrote: > >> Any suggestions for how to handle annotating it? We could turn it into >> a fake PR and mark it up using github's PR comments. > > I think that's a good idea. It is very easy for people to ask > questions about any change that they don't understand on the exact lines > that are confusing them. > > Also, I found it useful when converting Imagick to have a checklist of > everything that needed to be done, in a simple format, rather than the full > explanation of the changes at https://wiki.php.net/phpng-upgrading. That > allowed me to search for the things that needed fixing. > > You could then put links to the PR from checklist for an example of > the change in place. > regarding your ext/imagick port, please check the make logs here http://windows.php.net/downloads/pecl/snaps/imagick/3.2.0rc1/logs/ . How it looks, you also might find this tool useful https://github.com/johannes/clang-php-checker/ .
Thanks. Anatol -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
