On Sat, Feb 7, 2015 at 1:56 AM, Lester Caine <les...@lsces.co.uk> wrote:
> OK slowly getting back into raw code again ... > > Looking at imagick phpinfo problem ... > > > if (supported_formats) { > > for (i = 0; i < num_formats; i++) { > > smart_string_appends(&formats, > supported_formats[i]); > > if (i != (num_formats - 1)) { > > smart_string_appends(&formats, ", "); > > } > > IMAGICK_FREE_MAGICK_MEMORY(supported_formats[i]); > > } > > smart_string_0(&formats); > > #ifdef ZEND_ENGINE_3 > > php_info_print_table_row(2, "ImageMagick supported > formats", formats); > > #else > > php_info_print_table_row(2, "ImageMagick supported > formats", formats.s); > > #endif > > smart_string_free(&formats); > > IMAGICK_FREE_MAGICK_MEMORY(supported_formats); > > } > > This one of the few places I can find smart_string_appends used, and I > can't work out just where it's code is? Although what it should be doing > is fairly self explanatory ... except why the dropping of the .s for > ZEND_ENGINE_3 ? > I hope this is the right pointer. The String API changed completely in ZE3, see the Upgrading docs to PHPNG: https://wiki.php.net/phpng-upgrading#strings It takes much time wrapping your head around this new way, but I think in the end its better than before. > > supported_formats must have the list as it says there are 209 entries, > but why is there a problem doing something simple which works on the 5.x > builds. > > -- > Lester Caine - G8HFL > ----------------------------- > Contact - http://lsces.co.uk/wiki/?page=contact > L.S.Caine Electronic Services - http://lsces.co.uk > EnquirySolve - http://enquirysolve.com/ > Model Engineers Digital Workshop - http://medw.co.uk > Rainbow Digital Media - http://rainbowdigitalmedia.co.uk > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >