On Thu, Nov 12, 2015 at 7:09 AM, Côme Chilliet <c...@opensides.be> wrote:
> Le vendredi 6 novembre 2015, 11:43:58 Ferenc Kovacs a écrit : > > > > on the other hand functions like ftp_connect assumes the default port > when > > passed NULL: > > > > I'm fine with changing this for future versions but my understanding is > > that this BC break (along with some others) was introduced in a micro > > release (5.6.11 afair), so at least for 5.6 I would prefer restoring the > > old behavior and for 7.0 I'm fine with the change but please document it > in > > NEWS and UPGRADING so we can incorporate it in the docs. > > > > Ok, so I pushed a fix to treat NULL (and 0 for that matter, same as in > ftp_connect) into the default ldap port. > I pushed only to 5.6 as I think for 7 we should keep the error, it does > not makes much sense to accept NULL as port and the documentation does not > mention it. > > MCMic > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > thanks! -- Ferenc Kovács @Tyr43l - http://tyrael.hu
