On 03/30/2016 08:13 AM, Joe Watkins wrote:
Morning Dmitry,
So, I quickly reviewed the RFC and patch.
Static properties, and mixed declarations, are now explained in the RFC.
Thanks. I'm not agree with decisions, but RFC is more complete now.
It would be great to have "static" typed properties at the same time,
but this may be more difficult.
Mixed declarations decision looks wrong to me, but right to some others.
From implementation point of view, it's not a big problem to change it.
I made a couple of changes to the fetch_obj_w stuff, I'd be grateful if
you could review that ... I didn't think I had got all possible
combinations, should be bit better, and drier ...
The overflow related stuff, I'll fix and explain in the RFC, but I'll
let you have a go at perf stuff, and other outstanding things now ...
*/me leaves patch alone*
OK. I'll try to do something today.
Thanks. Dmitry.
Cheers
Joe
On Wed, Mar 30, 2016 at 5:26 AM, Joe Watkins <pthre...@pthreads.org> wrote:
Morning Pieere, Dmitry, all ...
Actually it's not so simple ... for object properties we have ASSIGN_OBJ
opcode, but we don't have a special opcode for static properties, and
ASSIGN doesn't have any information about where the var came from, and nor
should it have that information ...
I'm going to stick the original decision, static properties don't belong
until typed variables are a thing ...
Cheers
Joe
On Wed, Mar 30, 2016 at 4:57 AM, Pierre Joye <pierre....@gmail.com> wrote:
On Mar 30, 2016 10:17 AM, "Joe Watkins" <pthre...@pthreads.org> wrote:
Morning Dmitry,
1) static typed properties are prohibited. why?
Feels like that's a separate feature, static properties are as good as
makes no difference, global variables.
Instance properties, the engine has good control over their
manipulation,
for static properties it doesn't, it's not impossible, but feels
separate.
Internally different but from users perspective it is the same (a class
property). It would be nice to support that at the same time to avoid
confusion.
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
