This can potentially break some cached flags somewhere, and is a BC break: any rationale behind the change?
On Wed, 25 Jul 2018, 17:01 Dmitry Stogov, <dmi...@zend.com> wrote: > Hi, > > > I tried to fix ZEND_ACC_* flags mess. > > > https://gist.github.com/dstogov/3b6ae377c17524b219670960cf98f8c1 > > > The patch specifies flags meaning, and reorder them according to meaning > and frequency of usage (this allows generation of shorter instructions on > x86). > > Unfortunately, the patch breaks few reflection based tests that relay on > binary modifiers values. > > > Do you think, it it's OK to commit thin into 7.3 or better to wait for > branching? > > > Thanks. Dmitry. >
