On Wed, Jul 25, 2018 at 11:01 AM, Dmitry Stogov <dmi...@zend.com> wrote: > > I tried to fix ZEND_ACC_* flags mess. > > https://gist.github.com/dstogov/3b6ae377c17524b219670960cf98f8c1 > > > The patch specifies flags meaning, and reorder them according to meaning and > frequency of usage (this allows generation of shorter instructions on x86). > Unfortunately, the patch breaks few reflection based tests that relay on > binary modifiers values. > Documentation part: LOVE 💖 LOVE 💖 LOVE
Renumbering part: Eh, could save that for 8.0, but I won't complain about it in 7.4. Whichever version it lands in, please make a bump to ZEND_MODULE_API_NO part of the commit, and a comment in UPGRADING.INTERNALS as well. -Sara -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
