On Wed, Jan 2, 2019 at 6:11 PM Nikita Popov <nikita....@gmail.com> wrote:
> On Wed, Jan 2, 2019 at 12:33 PM Zeev Suraski <z...@php.net> wrote: > I don't expect this to be a particularly large issue for two reasons: > > 1. Not many people use this. I'm sure that there *are* people who use this > and use it intentionally, but I've only ever seen reference to this issue > as a bug or a gotcha. > 2. Even if somebody is using this functionality, the only thing that's > going to happen is that their number display switches from 1,5 to 1.5. > That's a minor UX regression, not a broken application. It's something that > will have to be fixed, but it's also not critical, and for a legacy > application one might even not bother. > FWIW, neither of these are very convincing for me: 1. I'm not sure what you mean "not many people use this"? People don't convert floats to strings? 2. Perhaps you meant they weren't proactively relying on this behavior, which could be true - but it doesn't matter whether people were expecting or otherwise desiring this behavior when they wrote the code. Whatever the current behavior is - they adjusted for it, and ended up using it, consequently relying on it. 3. I view a UX change as a big deal. As we should in a language that is very commonly used to create UI. 4. This could effect not only UX, but also integration code. You could have PHP output feeding into something else - and suddenly, the format breaks. With the fix HAVING to be in the other side, no less. I fail to understand how we could consider changing such a fundamental element (to-string behavior of floats) without an in-depth discussion. We mustn't. I think we should just put this to an RFC vote. We regularly have these > types of discussions, and people just disagree about level of anticipated > BC break relative to benefit of the change. > The point of an RFC is, in fact, to have these discussions. This is what we're doing right now. This is what the RFC process is all about - not the vote. It sounds to me as if you're saying "what's the point of discussing, let's just vote" (waiting out the two weeks as needed), with which I would wholeheartedly disagree. Apologies if you meant something else. Zeev
