Oh to be absolutely clear, I'm talking about commits that *only* touch these non-source files ...
Cheers Joe On Fri, 7 Jun 2019 at 13:07, Joe Watkins <krak...@gmail.com> wrote: > Hi Marco, > > It wasn't a topic for discussion, it was a request to committers in > php-src. > > We do not need to run CI for NEWS changes, and we can definitely be sure > it doesn't effect the build. > > The same goes for other files like UPGRADING, UPGRADING.INTERNALS ... > > Under normal circumstances these files are not changed by themslves, but > occasionally, we have to correct one of these files and omitting [ci ski] > puts the build behind by up to an hour ... > > Cheers > Joe > > On Fri, 7 Jun 2019 at 13:02, Marco Pivetta <ocram...@gmail.com> wrote: > >> Please avoid doing that: >> >> 1. Commit messages are for humans >> 2. You never know what can break, that's why it's "continuous" there >> (besides religious views around what "continuous integration" means) >> >> On Fri, Jun 7, 2019, 12:51 Joe Watkins <krak...@php.net> wrote: >> >> > Hi all, >> > >> > Just a friendly reminder that when we're committing changes to files >> that >> > do not contain source, test code, or build configuration, it's helpful >> to >> > include [ci skip] in the commit message. Omitting it can put our CI >> quite >> > far behind. >> > >> > Cheers >> > Joe >> > >> >
