Hi Bill,
On Fri, Jan 10, 2014 at 03:07:26PM -0700, Bill Sumner wrote:
> Bill Sumner (6):
> Crashdump-Accepting-Active-IOMMU-Flags-and-Prototype
> Crashdump-Accepting-Active-IOMMU-Utility-functions
> Crashdump-Accepting-Active-IOMMU-Domain-Interfaces
> Crashdump-Accepting-Active-IOMMU-Copy-Translations
> Crashdump-Accepting-Active-IOMMU-Debug-Print-IOMMU
> Crashdump-Accepting-Active-IOMMU-Call-From-Mainline
>
> drivers/iommu/intel-iommu.c | 1293
> ++++++++++++++++++++++++++++++++++++++++---
> 1 file changed, 1225 insertions(+), 68 deletions(-)
This is a pretty big change, before merging I would like to get more
eyes on it. Please make sure you get more reviews on the code and the
general concept. A few things I noticed while looking at it:
* You put a lot of code into #define CONFIG_CRASH_DUMP. Isn't the same
approach necessary to for KEXEC?
* Please get rid of all the pr_debug stuff.
* I think it makes sense to put the functions to access the IOMMU
configuration values of the old kernel into a new file. This is better
than adding over 1000 new lines to intel-iommu.c
* I have seen your new single-patch for this change. A single patch with
more than 1200 changed lines is not something anyone is willing to
review. Please split the patches again in a meaningful and bisectable
way.
Thanks,
Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
