> - BUG_ON(!ops); > - WARN_ON_ONCE(dev && !dev->coherent_dma_mask); > - > if (dma_alloc_from_dev_coherent(dev, size, dma_handle, &cpu_addr)) > return cpu_addr; > > + BUG_ON(!ops); > + WARN_ON_ONCE(dev && !dev->coherent_dma_mask);
I think doing dma on a device without ops is completely broken no matter what you think of it, so I very much disagree with that part of the change. Also while I don't think not having a dma mask is a good idea even for a driver purely using dma coherent pools. If the pools really are on the device itself I can see why it might not matter, but for the case commonly used on some ARM SOCs where we just reserve memory for certain devices from a system pool it very much does matter. There really is no good excuse to not set a coherent mask in the drivers. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
