Hi Christoph, Geoff, [ CC-ing Geoff to give him an opportunity to chime in about the PS3 part. ]
> > Here are three other regressions related to the coherent mask WARN_ON_ONCE: > > They are a pretty strong indication that yes, you should really set > the coherent mask if you ever do coherent allocations.. I'm unfortunately unfamiliar with the USB drivers for the PS3. Geoff, what do you think about setting a coherent mask? Christoph, what mask value would you suggest for the PS2 driver? Typical DMA addresses 0-0x200000 are mapped to 0x1c000000-0x1c200000 and is memory managed exclusively by the IOP. Robin indicated that DMA_BIT_MASK(20) or a nonzero but useless value such as 1 are possibly candidates. It seems quite unclear what the coherent mask actually means in this case, doesn't it? Fredrik _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu