On Wed, 2020-07-01 at 10:17 +0800, Yong Wu wrote:
> On Mon, 2020-06-29 at 15:13 +0800, Chao Hao wrote:
> > For iommu offset=0x48 register, only the previous mt8173/mt8183 use the
> > name STANDARD_AXI_MODE, all the latest SoC extend the register more
> > feature by different bits, for example: axi_mode, in_order_en, coherent_en
> > and so on. So rename REG_MMU_MISC_CTRL may be more proper.
> >
> > This patch only rename the register name, no functional change.
> >
> > Signed-off-by: Chao Hao <chao....@mediatek.com>
> > Reviewed-by: Yong Wu <yong...@mediatek.com>
> > Reviewed-by: Matthias Brugger <matthias....@gmail.com>
> > ---
> > drivers/iommu/mtk_iommu.c | 14 +++++++-------
> > drivers/iommu/mtk_iommu.h | 2 +-
> > 2 files changed, 8 insertions(+), 8 deletions(-)
>
> ...
>
> > diff --git a/drivers/iommu/mtk_iommu.h b/drivers/iommu/mtk_iommu.h
> > index ea949a324e33..1b6ea839b92c 100644
> > --- a/drivers/iommu/mtk_iommu.h
> > +++ b/drivers/iommu/mtk_iommu.h
> > @@ -18,7 +18,7 @@
> > #include <soc/mediatek/smi.h>
> >
> > struct mtk_iommu_suspend_reg {
> > - u32 standard_axi_mode;
> > + u32 misc_ctrl;
>
> Here will cause build fail for v1:
>
> drivers/iommu/mtk_iommu_v1.c:675:20: error: 'struct
> mtk_iommu_suspend_reg' has no member named 'standard_axi_mode'
> writel_relaxed(reg->standard_axi_mode,
> ^
>
> We could change something like:
>
> union {
> u32 standard_axi_mode; /* only for v1 */
> u32 misc_ctrl; /* only for v2 */
> };
>
> > u32 dcm_dis;
> > u32 ctrl_reg;
> > u32 int_control0;
ok, I will fix it in next version, thanks
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
