On quinta-feira, 2 de junho de 2016 09:37:44 BRT Gregg Reynolds wrote: > Great! Maybe I should take a look at the Windows changes. I assume > they're all in the windows-port branch?
That is correct. > Here's what I've done so far: cloned a fresh copy of the master branch, > created a darwin branch, and now I'm trying to follow the instructions on > the wiki (e.g. https://wiki.iotivity.org/submitting_to_gerrit). But I have > a few questions. > > For example, is it ok to push multiple commits in one go? Otherwise it > looks like I would have to assign reviewers for every little commit. I > assume smaller commits are better. You can push multiple commits in one go, indeed. We prefer "atomic" commits, meaning the smallest change that logically goes together. Sometimes, that's big, sometimes that's small. That's up to you. PS: please send me an email if you need my attention to review something. My gerrit folder is very full and I often ignore it... -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center
