Hi Phils, >From the release view, I think current build script has some issues to secure the overall quality. Frequently we faced the error in the build script and it caused the build failure from specific preprocessor options. To lessen the release burden from the next time in case of patch release such as 1.3.1 or 1.3.2, it needs to be applied into 1.3-rel I expect.
BR, Uze Choi -----Original Message----- From: [email protected] [mailto:iotivity-dev- bounces at lists.iotivity.org] On Behalf Of Philippe Coval Sent: Saturday, June 03, 2017 10:17 AM To: IoTivity Developer List Subject: Re: [dev] note on sconscript cleanups Thank Mats for your help on that, this is appreciated, I think master is the good place to prepare next release, 1.4-rel or 2.0-rel ? But I am a bit reluctant to change all in 1.3-rel, unless there is valid reason to do that (regressions etc). and it needs to be tracked off course. Last advice, all build related changes are welcome to be committed progressively (per module), then we can find out regression more easily than we did on recent patches for windows (we had to revert big patches) Regards On 03/06/17 09:00, Mats Wichmann wrote: > There's a bunch of stuff that could clean up the build scripts to be > more readable, more maintainable, and in some cases more correct (e.g > the situation where some of the extlibs scripts are called many times, > which is just plain not the way scons is supposed to work). > > Step one of that is converting them into a consistent style. I didn't > want to push any of this to master until 1.3 was released, since > changes often seem to touch the scons scripts as well, and that could > cause some headaches in keeping master and 1.3-rel synced - mergebacks > would not necessarily be trivial. > s MAts > So 1.3 is out and I've done some of these against master (using a > tool, but with manual inspection for sanity checking)... and now it > turns out > 1.3 is going to stay open for quite a while yet. So not sure where > these will be able to go. > > So far, I've sent up seven patchsets for seven subdirectories of > iotivity, covering 54 of the build scripts. Pending are the resource > subdirectory (82 scripts) and the service subdirectory (61 scripts). > At this point I'm unsure who wants/needs to review them, or if doing > this at this time turns out to be a bad idea since 1.3 work remains pending. > I only assigned reviewers on one of them so far, and two have > inexplicably failed builds - jenkins apparently is still fragile since > there were no functional changes from any of the patchsets, so it > should be impossible to fail. > > If people want to review these, let me know and I'll add you. > Repeating, this particular set of patches only reformats things, it > does not change anything except in a few cases the content of text > messages printed out if there's an issue. > _______________________________________________ > iotivity-dev mailing list > iotivity-dev at lists.iotivity.org > https://lists.iotivity.org/mailman/listinfo/iotivity-dev _______________________________________________ iotivity-dev mailing list iotivity-dev at lists.iotivity.org https://lists.iotivity.org/mailman/listinfo/iotivity-dev
