I think you have already started adding me to the reviews. Please keep adding me.
Thanks for the work. The changes you have done are simple cleanup, that was definitely needed. George N. -----Original Message----- From: iotivity-dev-bounces at lists.iotivity.org [mailto:[email protected]] On Behalf Of Mats Wichmann Sent: Friday, June 2, 2017 5:01 PM To: IoTivity Developer List <iotivity-dev at lists.iotivity.org> Subject: [dev] note on sconscript cleanups There's a bunch of stuff that could clean up the build scripts to be more readable, more maintainable, and in some cases more correct (e.g the situation where some of the extlibs scripts are called many times, which is just plain not the way scons is supposed to work). Step one of that is converting them into a consistent style. I didn't want to push any of this to master until 1.3 was released, since changes often seem to touch the scons scripts as well, and that could cause some headaches in keeping master and 1.3-rel synced - mergebacks would not necessarily be trivial. So 1.3 is out and I've done some of these against master (using a tool, but with manual inspection for sanity checking)... and now it turns out 1.3 is going to stay open for quite a while yet. So not sure where these will be able to go. So far, I've sent up seven patchsets for seven subdirectories of iotivity, covering 54 of the build scripts. Pending are the resource subdirectory (82 scripts) and the service subdirectory (61 scripts). At this point I'm unsure who wants/needs to review them, or if doing this at this time turns out to be a bad idea since 1.3 work remains pending. I only assigned reviewers on one of them so far, and two have inexplicably failed builds - jenkins apparently is still fragile since there were no functional changes from any of the patchsets, so it should be impossible to fail. If people want to review these, let me know and I'll add you. Repeating, this particular set of patches only reformats things, it does not change anything except in a few cases the content of text messages printed out if there's an issue. _______________________________________________ iotivity-dev mailing list iotivity-dev at lists.iotivity.org https://lists.iotivity.org/mailman/listinfo/iotivity-dev
