We've explored splitting the patch into multiple chunks before, and decided it was a bad idea. The only value it appears to add is making the patch files more human-readable, but it complicates the process to create or update the patch files in order to make a change or update mbedTLS, and then adds more patch apply steps to the build. This has already been an unreliable build step and I oppose making it moreso.
Our intention was always that these patches would eventually be taken by the upstream, and our additions to ocf.patch would eventually be taken back out as part of updating to a newer version of mbedTLS with our additions. We didn't expect it'd be this difficult to get any attention to our pull requests! -----Original Message----- From: iotivity-dev-bounces at lists.iotivity.org [mailto:[email protected]] On Behalf Of Thiago Macieira Sent: Monday, June 12, 2017 9:51 PM To: iotivity-dev at lists.iotivity.org Subject: Re: [dev] jenkins completely broken On segunda-feira, 12 de junho de 2017 17:34:04 PDT Mats Wichmann wrote: > as far as I can see, the push to mbedtls 2.4.2 broke the patch that is > applied on top of that repository. I'm seeing 100% of the builders > fail now, with these sorts of messages: Let's start by cleaning up that patch. Can we erase it and recreate in smaller chunks? Each file must have the number of the upstream pull request. I contacted Microsoft and obtained the following list for theirs: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FARMmbed%2Fmbedtls%2Fpull%2F730&data=02%7C01%7Ckkane%40microsoft.com%7C847d02badd9a4db0a77e08d4b217ecc5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636329263231376818&sdata=AZ3mhZpQE380CxEmW7245zBEVhVA%2FTPyGQLMvXmEO64%3D&reserved=0 https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FARMmbed%2Fmbedtls%2Fpull%2F731&data=02%7C01%7Ckkane%40microsoft.com%7C847d02badd9a4db0a77e08d4b217ecc5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636329263231376818&sdata=dR8TS1fzVRInk44mEsps66YaC5BJ1Otjx7g6WvUtxbI%3D&reserved=0 https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FARMmbed%2Fmbedtls%2Fpull%2F858&data=02%7C01%7Ckkane%40microsoft.com%7C847d02badd9a4db0a77e08d4b217ecc5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636329263231376818&sdata=nqqLIA4mKJUYTgYpr%2BpF6sBmC6Cd%2B9MBvuJL8Oar9AY%3D&reserved=0 Can Samsung developers provide the link to theirs? -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center _______________________________________________ iotivity-dev mailing list iotivity-dev at lists.iotivity.org https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.iotivity.org%2Fmailman%2Flistinfo%2Fiotivity-dev&data=02%7C01%7Ckkane%40microsoft.com%7C847d02badd9a4db0a77e08d4b217ecc5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636329263231376818&sdata=OW2ep5f8LQFebOPSmb2PpK3NKdEkLX%2FMB2CLtLws8wg%3D&reserved=0
