On 13/06/17 17:17, Mats Wichmann wrote:
> On 06/13/2017 08:30 AM, Kevin Kane via iotivity-dev wrote:
>> We've explored splitting the patch into multiple chunks before, and decided 
>> it was a bad idea. The only value it appears to add is making the patch 
>> files more human-readable, but it complicates the process to create or 
>> update the patch files in order to make a change or update mbedTLS, and then 
>> adds more patch apply steps to the build. This has already been an 
>> unreliable build step and I oppose making it moreso.
>>
>> Our intention was always that these patches would eventually be taken by the 
>> upstream, and our additions to ocf.patch would eventually be taken back out 
>> as part of updating to a newer version of mbedTLS with our additions. We 
>> didn't expect it'd be this difficult to get any attention to our pull 
>> requests!
>
> What we have now, after the patch
> (5456220c850bd580b9bafdb82c356e9fb9c34f02), seems to be back to as good
> as before...

But still not in 1.3-rel,
I didn't submit it there, to create more confusion

>   except on the Mac builder, which is not automatically
> pulling the new revision... not sure how this happens, hopefully someone
> can kick it.
(...)
> The other builders got past this point, so something in the scripts
> driving the process on jenkins is different here?

yea, I've reported a week ago, that osx had issue,
let's wait for CJ on IRC to explain how to sort this out.

Track:
https://jira.iotivity.org/browse/IOT-1928


By the way, the role of OSX maintainer is still open,
don't be shy :)


-- 
mailto:philippe.coval at osg.samsung.com gpg:0x467094BC
https://blogs.s-osg.org/author/pcoval/

Reply via email to