On Tue, Jan 8, 2013 at 12:42 PM, Liebig, Holger <holger.lie...@ts.fujitsu.com> wrote: >> > >> > Hi, >> > >> > The lib/ipmi_sdr.c above comment "/* SR2300, non-redundant, PSx present >> */" >> > The missing break is intentional due to redundancy, right? >> >> [Liebig, Holger] >> I would say no, but who knows for sure without Intel documentation about >> the OEM SDR's in this particular quite old system from 2003. The referenced >> data oem->data[8] might technically even be out of bounds, given the record >> indicated only a length of 8 in total. >> > > [Liebig, Holger] > To answer this myself: in > http://download.intel.com/support/motherboards/server/sb/imm_tps_12.pdf page > 200 is a list and description of Intel OEM SDRs including the Power Unit Map > SDR type. The same information can be found in a dusty yellow cover document > from 2004 for the ESB2 BMC from Intel. A real world SDR including such an OEM > SDR can be found on > http://communities.intel.com/thread/11855?start=15&tstart=0, so this seems to > be a common OEM SDR type for Intel systems. > > Based on this information: > - a break for the case 8 is indeed missing > - case 8 should output the PSU sensor number from oem->data[7] instead of > oem->data[8] since only one PSU sensor number is available. > - the comments for case 8 and case 9 are misleading and should be swapped > - references to specific system codes (SR2300/SR1300) could be removed > - the "redundancy available" information should evaluate the "Power Supplies > Required" field of the SDR and not simply rely on the number of PSU sensors > being > 1. The sample in table 107 on page 200 requires 2 PSU for the system > to work and has 3 PSU sensors (2+1 redundancy) > > Holger >
Thank you for research, Holger. Z. ------------------------------------------------------------------------------ Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS and more. Get SQL Server skills now (including 2012) with LearnDevNow - 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only - learn more at: http://p.sf.net/sfu/learnmore_122512 _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
