This is what this patch is fixing. Here is what 'sdr help' looks like
before the changes:
dg:speedy:build(master) => src/ipmitool sdr help
Could not open device at /dev/ipmi0 or /dev/ipmi/0 or /dev/ipmidev/0:
No such file or directory
SDR Commands: list | elist [all|full|compact|event|mcloc|fru|generic]
all All SDR Records
full Full Sensor Record
compact Compact Sensor Record
event Event-Only Sensor Record
mcloc Management Controller Locator Record
fru FRU Locator Record
generic Generic Device Locator Record
type [sensor type]
list Get a list of available sensor types
get Retrieve the state of a specified sensor
info
Display information about the repository itself
entity <id>[.<instance>]
Display all sensors associated with an entity
dump <file>
Dump raw SDR data to a file
fill
sensors Creates the SDR repository for the
current configuration
nosat Creates the SDR repository for the
current configuration, without satellite scan
file <file> Load SDR repository from a file
range <range> Load SDR repository from a provided
list or range
- Use , for list or - for range
(Ex.: 0x28,0x32,0x40-0x44)
This is what it looks like after the changes:
dg:speedy:build(master) => src/ipmitool sdr help
Could not open device at /dev/ipmi0 or /dev/ipmi/0 or /dev/ipmidev/0:
No such file or directory
SDR Commands:
list | elist [option]. Available options are:
all All SDR Records
full Full Sensor Record
compact Compact Sensor Record
event Event-Only Sensor Record
mcloc Management Controller Locator Record
fru FRU Locator Record
generic Generic Device Locator Record
type [sensor type] | list
Retrieve sensors matching [sensor type].
[sensor type] can be specified as hex value or a string.
list Get a list of available sensor types
get [Sensor ID string]
Retrieve the first sensor with Sensor ID matching
[Sensor ID string].
info
Display information about the repository itself
entity <id>[.<instance>]
Display all sensors associated with an entity
dump <file>
Dump raw SDR data to a file
fill [option]. Available options:
sensors Creates the SDR repository for the current
configuration.
nosat Creates the SDR repository for the current
configuration, without satellite scan.
file <file> Load SDR repository from a file
range <range> Load SDR repository from a provided list
or range
Use , for list or - for range
(Ex.: 0x28,0x32,0x40-0x44)
Note that long lines are broken up so that things don't go past 80
columns and the help has been clarified and updated. It's not just
messing with the formatting of the code.
thanks
dan
On Thu, Apr 4, 2013 at 1:52 PM, Dan Gora <d...@adax.com> wrote:
> On Thu, Apr 4, 2013 at 9:48 AM, Zdenek Styblik <zdenek.styb...@gmail.com>
> wrote:
>> On Fri, Mar 22, 2013 at 1:15 AM, Dan Gora <d...@adax.com> wrote:
>>> Fixed the formatting of the help command to make it clearer what
>>> options the sdr command has.
>>>
>>
>> Ok, I did take a closer look at this diff:
>> 1st part - useless and won't be committed
>> 2nd part - we've talked about it already, it will be changed to
>> lprintf(LOG_ERR, ...); ok to commit after the change
>> 3rd part - sorry, but NACK.
>> 4th part - ok to commit
>
> Ok, I really have no idea what "parts" you are referring to here.
> Also, can you give a reason for NACKing whatever it is that you are
> NACKing?
>
> thanks
> dan
--
Dan Gora
Software Engineer
Adax, Inc.
Av Dona Maria Alves, 1070 Casa 5
Centro
Ubatuba, SP
CEP 11680-000
Brasil
Tel: +55 (12) 3833-1021 (Brazil and outside of US)
: +1 (510) 859-4801 (Inside of US)
: dan_gora (Skype)
email: d...@adax.com
------------------------------------------------------------------------------
Minimize network downtime and maximize team effectiveness.
Reduce network management and security costs.Learn how to hire
the most talented Cisco Certified professionals. Visit the
Employer Resources Portal
http://www.cisco.com/web/learning/employer_resources/index.html
_______________________________________________
Ipmitool-devel mailing list
Ipmitool-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
