On Thu, Apr 4, 2013 at 9:57 PM, Dan Gora <d...@adax.com> wrote: > On Thu, Apr 4, 2013 at 4:52 PM, Zdenek Styblik <zdenek.styb...@gmail.com> > wrote: >> Sure. I've found two issues with help "update". The first is, I don't >> like new help output very much, to be honest. That doesn't mean you > > Well it would help if you could actually say what you don't like about > it. I think that it's much clearer and actually fixes problems with > the help output from before. > >> should re-work it. Let me come up with my version. >> The second issue I have is formatting. I understand you want to >> improve code formatting and I'm all for that. But replacing tabs with >> (one) white space and/or removing white spaces etc.? I really don't >> see it as a way to go. >> >> ~~~ >> <this is tabbed>lprintf(LOG_ERR, >> "whoo, where does this belong?" >> <this is tabbed>whatever_is_here >> ~~~ >> >> I don't find it very nice, no. > > This is like this for a very important reason. > > By starting all of the strings on a new line at the same offset, it > becomes much, much easier to actually format the text inside the > quotes. You can see in your text editor exactly how everything will > line up. By placing them on the same line, not only does the line > wrap, but you have to actually run the program to see how the text is > going to display on the screen. > >> If anything, string passed to printf/lprintf can be split. Does it >> make sense for something like sentences or some long text? I'm not >> sure. And if I remember correctly, even GNU coding standards, which >> are considered ancient and obsolete nowadays, allow lines over 80 >> chars if there is no (intelligent?) way to split it. > > The whole point here is that you don't _want_ the strings to be longer > than 80 chars. By placing them on their own line you can see > _without_ having to run the program that the line will not wrap when > it is run. > > thanks > dan
Really *shrug*. (now, you knew it had to come some time) Sometimes I even ask myself whether 80 chars width is still relevant nowadays. Relevant for majority, that is. And I don't mean only code formatting now, but output as well. Oh, and I really mean it. Anyway, what you've written makes sense, sort of. But don't do such thing in the middle of the code. Say, if this is done in function which does nothing else just these print-outs, that's fine. I don't think it's fine doing it in some nested code(not 100% relevant to 'ipmi_sdr.c' as the large help print-out is right at the beginning). In the end, it will be better to shove that help text into it's own function. Z. ------------------------------------------------------------------------------ Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html _______________________________________________ Ipmitool-devel mailing list Ipmitool-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ipmitool-devel
