[
https://issues.apache.org/jira/browse/IMPALA-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489756#comment-16489756
]
ASF subversion and git services commented on IMPALA-6953:
---------------------------------------------------------
Commit 890457c01878cb3ee3b2045b63bbcabf772d88bc in impala's branch
refs/heads/master from [[email protected]]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=890457c ]
IMPALA-6953: part 1: clean up DiskIoMgr
There should be no behavioural changes as a result of
this refactoring.
Make DiskQueue an encapsulated class.
Remove friend classes where possible, either by using public
methods or moving code between classes.
Move method into protected in some cases.
Split GetNextRequestRange() into two methods that
operate on DiskQueue and RequestContext state. The methods
belong to the respective classes.
Reduce transitive #include dependencies to hopefully help
with build time.
Testing:
Ran core tests.
Change-Id: I5a6e393f8c01d10143cbac91108af37f6498c1b1
Reviewed-on: http://gerrit.cloudera.org:8080/10245
Reviewed-by: Tim Armstrong <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
> Improve encapsulation within DiskIoMgr
> --------------------------------------
>
> Key: IMPALA-6953
> URL: https://issues.apache.org/jira/browse/IMPALA-6953
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Reporter: Tim Armstrong
> Assignee: Tim Armstrong
> Priority: Major
>
> While DiskIoMgr is still fresh in my mind, I should do some refactoring to
> improve the encapsulation within io::. Currently lots of classes are friends
> with each other and some code is not in the most appropriate class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
