[ 
https://issues.apache.org/jira/browse/IMPALA-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506168#comment-16506168
 ] 

ASF subversion and git services commented on IMPALA-6953:
---------------------------------------------------------

Commit 56d331f28417d02a908da08c1be34727fb3c3b04 in impala's branch 
refs/heads/master from [[email protected]]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=56d331f ]

IMPALA-6953: part 2: clean up DiskIoMgr

Follow-on changes.

Made further mechanical changes that involved a lot of code motion:
* Move code that manipulates RequestContext internal state to
  RequestContext
* Don't use protected friend pattern that doesn't work as I thought
* Remove some unused member variables and arguments
* Move PerDiskState definition into .cc

Change-Id: Ie82849652266b6660dd479689e5134273b172eb5
Reviewed-on: http://gerrit.cloudera.org:8080/10479
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>


> Improve encapsulation within DiskIoMgr
> --------------------------------------
>
>                 Key: IMPALA-6953
>                 URL: https://issues.apache.org/jira/browse/IMPALA-6953
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend
>            Reporter: Tim Armstrong
>            Assignee: Tim Armstrong
>            Priority: Major
>
> While DiskIoMgr is still fresh in my mind, I should do some refactoring to 
> improve the encapsulation within io::. Currently lots of classes are friends 
> with each other and some code is not in the most appropriate class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to