[ https://issues.apache.org/jira/browse/IMPALA-8359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16810091#comment-16810091 ]
ASF subversion and git services commented on IMPALA-8359: --------------------------------------------------------- Commit a0a20cdf9adcb899e4bb04e3f9278077dc2b52c0 in impala's branch refs/heads/master from Zoltan Borok-Nagy [ https://gitbox.apache.org/repos/asf?p=impala.git;h=a0a20cd ] IMPALA-8359: Fix coverage data generation for impalads impala::InitCommonRuntime() sets a signal handler for SIGTERM. It calls _exit(0) which causes normal program termination without cleaning up, i.e. no destructors are called etc. Gcov writes the coverage data in this cleanup phase, so calling _exit() prevents flushing coverage data. Now the '-codecoverage' flag also defines a macro named CODE_COVERAGE_ENABLED. If this macro is defined we explicitly call __gcov_flush() before calling _exit(). I tested manually. Change-Id: I9be1e1e73b6cfc3557077f763aee4dbfcc7a2d27 Reviewed-on: http://gerrit.cloudera.org:8080/12858 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> > Coverage measurement is not working for Impala daemons > ------------------------------------------------------ > > Key: IMPALA-8359 > URL: https://issues.apache.org/jira/browse/IMPALA-8359 > Project: IMPALA > Issue Type: Bug > Reporter: Zoltán Borók-Nagy > Assignee: Zoltán Borók-Nagy > Priority: Major > > Currently code coverage measurement only works for backend tests. > Impala daemons don't write .gcda files when they terminate because they set a > signal handler for SIGTERM. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org