[
https://issues.apache.org/jira/browse/IMPALA-15110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18109149#comment-18109149
]
ASF subversion and git services commented on IMPALA-15110:
----------------------------------------------------------
Commit 119bd72f3edd2ba77ea829f54b552775f178160c in impala's branch
refs/heads/master from Fang-Yu Rao
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=119bd72f3 ]
IMPALA-15110: Change the overridden methods in Catalog after HIVE-26537
HIVE-26537 renamed some methods in AbstractThriftHiveMetastore that
were overridden in MetastoreServiceHandler and
CatalogMetastoreServiceHandler, which are instantiated in
CatalogHmsSyncToLatestEventIdTest. Due to this, requests from a
HiveMetaStoreClient were routed to the methods for which there was no
implementation in Impala, causing this Java test to fail. This patch
fixed the issue by renaming those overridden methods in Impala.
After renaming those overridden methods in Impala, we also had to fix
some end-to-end tests in test_metastore_service.py in which the
catalog server is started with "--start_hms_server=true" so that the
Hive MetaStore client will submit the requests to the renamed API's.
Testing:
- Verified that CatalogHmsSyncToLatestEventIdTest is fixed with this
patch.
- Verified that the tests in test_metastore_service.py in which the
catalog server is started with "--start_hms_server=true" are passed
with this patch.
Change-Id: Ia81ac8f5b0983e79531294faaf88cd9f452eebc9
Reviewed-on: http://gerrit.cloudera.org:8080/24483
Reviewed-by: Michael Smith <[email protected]>
Tested-by: Fang-Yu Rao <[email protected]>
> Change the overridden methods in Catalog after HIVE-26537
> ---------------------------------------------------------
>
> Key: IMPALA-15110
> URL: https://issues.apache.org/jira/browse/IMPALA-15110
> Project: IMPALA
> Issue Type: Task
> Reporter: Fang-Yu Rao
> Assignee: Fang-Yu Rao
> Priority: Major
>
> HIVE-26537 renamed some methods in AbstractThriftHiveMetastore that
> were overridden in MetastoreServiceHandler and
> CatalogMetastoreServiceHandler, which are instantiated in
> CatalogHmsSyncToLatestEventIdTest. Due to this, requests from a
> HiveMetaStoreClient were routed to the methods for which there was no
> implementation in Impala, causing this Java test to fail.
> We should fix the above if possible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
