[
https://issues.apache.org/jira/browse/ARTEMIS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248440#comment-15248440
]
ASF GitHub Bot commented on ARTEMIS-488:
----------------------------------------
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/469#discussion_r60292159
--- Diff:
tests/activemq5-unit-tests/src/main/resources/stomp/META-INF/services/org.apache.activemq.artemis.spi.core.protocol.ProtocolManagerFactory
---
@@ -0,0 +1 @@
+org.apache.activemq.artemis.core.protocol.stomp.StompProtocolManagerFactory
--- End diff --
Adding this file under testsuite would be a hack.
The problem with that is if we ever make any changes, or need any fix..
nobody will figure out what happened here.
Please remove this file from the testsuite, and if you need stomp protocol
manager just add the proper dependency through the pom.
> Fix OpenWire Test (Temp Queue removal and others)
> -------------------------------------------------
>
> Key: ARTEMIS-488
> URL: https://issues.apache.org/jira/browse/ARTEMIS-488
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: OpenWire
> Affects Versions: 1.2.0
> Reporter: Howard Gao
> Fix For: 1.3.0
>
>
> Temp Queue not deleted when connection is closed.
> Enable Stomp in openwire test because some test uses it.
> Remove unused code in opwnwire
> Wrong XA error code returned when xid is missing
> (ActiveMQXAConnectionFactory.testRollbackXaErrorCode)
> regression in ActiveMQSslConnectionFactoryTest (SSL related)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
