[
https://issues.apache.org/jira/browse/ARTEMIS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250203#comment-15250203
]
ASF GitHub Bot commented on ARTEMIS-488:
----------------------------------------
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/469#issuecomment-212502990
lets do it for next PRs.
The idea is that you keep concentrate within issues.. but you still rebase
and squash accordingly.
I usually have lots of small committs on my branch and then I squash them
accordingly to atomic issues before PR.
An example of a previous PR I worked on:
https://github.com/apache/activemq-artemis/pull/463
> Fix OpenWire Test (Temp Queue removal and others)
> -------------------------------------------------
>
> Key: ARTEMIS-488
> URL: https://issues.apache.org/jira/browse/ARTEMIS-488
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: OpenWire
> Affects Versions: 1.2.0
> Reporter: Howard Gao
> Fix For: 1.3.0
>
>
> Temp Queue not deleted when connection is closed.
> Enable Stomp in openwire test because some test uses it.
> Remove unused code in opwnwire
> Wrong XA error code returned when xid is missing
> (ActiveMQXAConnectionFactory.testRollbackXaErrorCode)
> regression in ActiveMQSslConnectionFactoryTest (SSL related)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
