[
https://issues.apache.org/jira/browse/ARTEMIS-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15960401#comment-15960401
]
ASF GitHub Bot commented on ARTEMIS-1043:
-----------------------------------------
GitHub user jmesnil reopened a pull request:
https://github.com/apache/activemq-artemis/pull/1178
(1.x) [ARTEMIS-1043] Support IPv6 in NettyConnector
Call IPV6Util.encloseHost when creating the uri used to send the HTTP
ugrade request to ensure that IPv6 address are properly enclosed.
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1043
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jmesnil/activemq-artemis
ARTEMIS-1043_NettyConnector_IPv6_1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1178.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1178
----
commit bdc15a9ed1a97b891f531acb9a785dd410cfdaf2
Author: Jeff Mesnil <jmes...@gmail.com>
Date: 2017-04-06T13:30:06Z
[ARTEMIS-1043] Support IPv6 in NettyConnector
Call IPV6Util.encloseHost when creating the uri used to send the HTTP
ugrade request to ensure that IPv6 address are properly enclosed.
JIRA: https://issues.apache.org/jira/browse/ARTEMIS-1043
----
> NettyConnector not working with IPv6 address
> --------------------------------------------
>
> Key: ARTEMIS-1043
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1043
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 1.5.3
> Reporter: Jeff Mesnil
> Fix For: 1.5.5, 2.next
>
>
> Artemis client doesn't correctly enclose IPv6 address when sending HTTP
> upgrade packet.
> According to [RFC2732 | https://www.ietf.org/rfc/rfc2732.txt], section {{2.
> Literal IPv6 Address Format in URL's Syntax}} and [HTTP header field
> definition
> specification|https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html],
> correct request URL should be enclosed like following one:
> {{http://[fe80::56ee:75ff:fe47:c83e]}}
> Following code snippet creates request for URL
> {{http://fe80::56ee:75ff:fe47:c83e}}
> {code}
> HashMap<String, Object> map = new HashMap<String, Object>();
> map.put("host", "fe80::56ee:75ff:fe47:c83e");
> map.put("port", "8080");
> map.put(TransportConstants.HTTP_UPGRADE_ENABLED_PROP_NAME, true);
> TransportConfiguration transportConfiguration = new
> TransportConfiguration(NettyConnectorFactory.class.getName(), map);
> ConnectionFactory cf =
> ActiveMQJMSClient.createConnectionFactoryWithoutHA(JMSFactoryType.CF,
> transportConfiguration);
> connection = cf.createConnection();
> {code}
> This works fine when client connects directly to the server. However it may
> cause problems when Artemis connects to proxy which expects IPv6 address
> correctly enclosed.
> Artemis client should detect IPv6 address and enclose it, so it conforms to
> specification.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
