[
https://issues.apache.org/jira/browse/ARTEMIS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212390#comment-16212390
]
ASF GitHub Bot commented on ARTEMIS-1472:
-----------------------------------------
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1601#discussion_r145910546
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/AMQPConnectionContext.java
---
@@ -143,13 +144,26 @@ public SASLResult getSASLResult() {
}
public void inputBuffer(ByteBuf buffer) {
- if (log.isTraceEnabled()) {
- ByteUtil.debugFrame(log, "Buffer Received ", buffer);
+ if (PN_TRACE_FRM) {
--- End diff --
I wouldn't personally tie these things together, to me they are separate
and just because I am asking proton to trace frames doesn't mean I want all the
bytes logged. I do the former often enough, but only very rarely do the latter.
When I do the latter its sometimes by using config toggle to activate
adding Nettys own byte logging debug LoggingHandler, though e.g for Qpid JMS we
do also have specific toggles to activate something more like this.
> Use PN_TRACE_FRAME as a signal for System.out logging on AMQP events
> --------------------------------------------------------------------
>
> Key: ARTEMIS-1472
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1472
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.3.0
> Reporter: clebert suconic
> Assignee: clebert suconic
> Fix For: 2.4.0
>
>
> AMQP developers will usually set PN_TRACE_FRM as a System.property to get out
> some information from Proton regarding the frame processing.
> It would be a nice idea to also throw some log.info when that property is set
> at Artemis.. around AMQP Processing, making it easier to Debug AMQP packets.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
