[
https://issues.apache.org/jira/browse/ARTEMIS-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212635#comment-16212635
]
ASF GitHub Bot commented on ARTEMIS-1472:
-----------------------------------------
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1601#discussion_r145959626
--- Diff:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/handler/ProtonHandler.java
---
@@ -443,7 +445,9 @@ private void dispatch() {
inDispatch = true;
while ((ev = collector.peek()) != null) {
for (EventHandler h : handlers) {
- if (log.isTraceEnabled()) {
+ if (PN_TRACE_FRM) {
+ log.info("Handling " + ev + " towards " + h);
--- End diff --
I'm not saying you don't need it, or that they often wont be combined
eventually, but I rarely ever want to turn that logging on at precisely the
same time as I might turn the frame logging on. They don't even go to the same
place, so I really feel they are separate and should have their own control
toggles as they do currently. I also wouldn't generally use another projects
magic toggle to control behaviour in this one.
> Use PN_TRACE_FRAME as a signal for System.out logging on AMQP events
> --------------------------------------------------------------------
>
> Key: ARTEMIS-1472
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1472
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.3.0
> Reporter: clebert suconic
> Assignee: clebert suconic
> Fix For: 2.4.0
>
>
> AMQP developers will usually set PN_TRACE_FRM as a System.property to get out
> some information from Proton regarding the frame processing.
> It would be a nice idea to also throw some log.info when that property is set
> at Artemis.. around AMQP Processing, making it easier to Debug AMQP packets.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
