[ https://issues.apache.org/jira/browse/AMQ-7015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16559734#comment-16559734 ]
Jeff Genender commented on AMQ-7015: ------------------------------------ The mbean is fine for small numbers of records. If you have a large XA batch, then the mbean can actually cause a OOM due to the amount. So I disagree. We need a way to configure this inside the broker as a part of recovery. I do not see this any different than the ignoreMissingJournalfiles/checkForCorruptJournalFiles parameters. Perhaps the user wants the setting permanent simply due to large batch sizes. This would certainly be an enhancement for that. With the MBean *and* this parameter, you have the best of doing it all ways. Your objection appears to be non-technical in nature. Can you please provide a technical reason to not do this? Unless you have one, I do not see a reason to hold this back. > Startup performance improvement when log contains prepared transactions. > ------------------------------------------------------------------------ > > Key: AMQ-7015 > URL: https://issues.apache.org/jira/browse/AMQ-7015 > Project: ActiveMQ > Issue Type: New Feature > Affects Versions: 5.15.4 > Reporter: Heath Kesler > Assignee: Jeff Genender > Priority: Minor > Fix For: 5.16.0, 5.15.5 > > > I have a KahaDB that's performing a recovery on each startup. > Digging deeper into it I've found that the issue is that the db.log contains > prepared transactions. > The MessageDatabase will discard those entries in memory, however it does not > remove transaction info from those messages (I believe that's by design). So > on each restart, the broker will find those entries and again discard them in > memory. > If I access the broker via JMX, I can go to the prepared XAs and execute a > clear on them one by one. > When i restart my broker, i don't have a recovery attempted again. > Performing a remove operation for each message can be very time consuming, so > i'd like to introduce an optional parameter to allow all prepared XAs to be > removed on recovery. > Please see my forth coming patch with unit test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)