[
https://issues.apache.org/jira/browse/ARTEMIS-2226?focusedWorklogId=193155&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-193155
]
ASF GitHub Bot logged work on ARTEMIS-2226:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Feb/19 02:05
Start Date: 01/Feb/19 02:05
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2528:
ARTEMIS-2226 last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252912679
##########
File path:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTProtocolManager.java
##########
@@ -62,11 +73,44 @@
List<BaseInterceptor> outgoingInterceptors) {
this.server = server;
this.updateInterceptors(incomingInterceptors, outgoingInterceptors);
+ server.getManagementService().addNotificationListener(this);
}
@Override
public void onNotification(Notification notification) {
- // TODO handle notifications
+ if (!(notification.getType() instanceof CoreNotificationType))
+ return;
+
+ CoreNotificationType type = (CoreNotificationType)
notification.getType();
+ if (type != CONSUMER_CREATED)
+ return;
+
+ TypedProperties props = notification.getProperties();
+
+ SimpleString protocolName =
props.getSimpleStringProperty(ManagementHelper.HDR_PROTOCOL_NAME);
+
+ if (protocolName == null ||
!protocolName.toString().equals(MQTTProtocolManagerFactory.MQTT_PROTOCOL_NAME))
+ return;
+
+ int distance = props.getIntProperty(ManagementHelper.HDR_DISTANCE);
+
+ if (distance > 0) {
+ SimpleString queueName =
props.getSimpleStringProperty(ManagementHelper.HDR_ROUTING_NAME);
+
+ Binding binding = server.getPostOffice().getBinding(queueName);
+ if (binding != null) {
+ Queue queue = (Queue) binding.getBindable();
+ String clientId =
props.getSimpleStringProperty(ManagementHelper.HDR_CLIENT_ID).toString();
+ //If the client ID represents a client already connected to the
server then the server MUST disconnect the existing client.
+ //Avoid consumers with the same client ID in the cluster appearing
at different nodes at the same time
+ Collection<Consumer> consumersSet = queue.getConsumers();
+ for (Consumer consumer : consumersSet) {
+ ServerConsumerImpl serverConsumer = (ServerConsumerImpl)
consumer;
Review comment:
what method? if youre talking re remoting connection you shouldnt be even
have added that new method, you simply want to close previous consumers, you
therefor should be calling close method on the serverconsumer, which is in
interface
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 193155)
Time Spent: 6h 40m (was: 6.5h)
> (MQTT)In the cluster,the last consumer connection should close the previous
> consumer connection
> -----------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-2226
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2226
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Shiping Liang
> Priority: Major
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
> Multiple consumers using the same clientId in the cluster, the last consumer
> connection should close the previous consumer connection!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
