[ https://issues.apache.org/jira/browse/ARTEMIS-2226?focusedWorklogId=193165&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-193165 ]
ASF GitHub Bot logged work on ARTEMIS-2226: ------------------------------------------- Author: ASF GitHub Bot Created on: 01/Feb/19 02:24 Start Date: 01/Feb/19 02:24 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on pull request #2528: ARTEMIS-2226 last consumer connection should close the previous consu… URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252915242 ########## File path: artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSession.java ########## @@ -204,4 +208,35 @@ public CoreMessageObjectPools getCoreMessageObjectPools() { public static Map<String, MQTTSessionState> getSessions() { return new HashMap<>(SESSIONS); } + + public MQTTSessionState getSessionStateFromSessionMap(String clientId) { + return SESSIONS.get(generateSessionStateKey(clientId)); + } + + public void putSessionStateIntoSessionMap(String clientId, MQTTSessionState state) { + SESSIONS.put(generateSessionStateKey(clientId), state); + } + + public void removeSessionStateFromSessionMap(String clientId) { + SESSIONS.remove(generateSessionStateKey(clientId)); + } + + /** + * When performing cluster testing, different nodes of the cluster are actually started in the same JVM process, Review comment: This is because we have state in a static, that is really bad, and simply needs to be addressed, see other comment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 193165) Time Spent: 7.5h (was: 7h 20m) > (MQTT)In the cluster,the last consumer connection should close the previous > consumer connection > ----------------------------------------------------------------------------------------------- > > Key: ARTEMIS-2226 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2226 > Project: ActiveMQ Artemis > Issue Type: Bug > Reporter: Shiping Liang > Priority: Major > Time Spent: 7.5h > Remaining Estimate: 0h > > Multiple consumers using the same clientId in the cluster, the last consumer > connection should close the previous consumer connection! -- This message was sent by Atlassian JIRA (v7.6.3#76005)