[
https://issues.apache.org/jira/browse/ARTEMIS-2226?focusedWorklogId=193451&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-193451
]
ASF GitHub Bot logged work on ARTEMIS-2226:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Feb/19 16:40
Start Date: 01/Feb/19 16:40
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2528:
ARTEMIS-2226 last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253117361
##########
File path:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTConnectionManager.java
##########
@@ -163,13 +163,7 @@ synchronized void disconnect(boolean failure) {
private MQTTSessionState getSessionState(String clientId) {
/* [MQTT-3.1.2-4] Attach an existing session if one exists otherwise
create a new one. */
- MQTTSessionState state = MQTTSession.SESSIONS.get(clientId);
- if (state == null) {
- state = new MQTTSessionState(clientId);
- MQTTSession.SESSIONS.put(clientId, state);
- }
-
- return state;
+ return MQTTSession.getSessionState(clientId,
session.getServer().getIdentity());
Review comment:
-1 Ive raised this already, simply shouldnt be having static map holding
state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 193451)
Time Spent: 12h 40m (was: 12.5h)
> (MQTT)In the cluster,the last consumer connection should close the previous
> consumer connection
> -----------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-2226
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2226
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Shiping Liang
> Priority: Major
> Time Spent: 12h 40m
> Remaining Estimate: 0h
>
> Multiple consumers using the same clientId in the cluster, the last consumer
> connection should close the previous consumer connection!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
