[jira] [Work logged] (ARTEMIS-2226) (MQTT)In the cluster,the last consumer connection should close the previous consumer connection

[ASF GitHub Bot (JIRA)]

     [ 
https://issues.apache.org/jira/browse/ARTEMIS-2226?focusedWorklogId=193816&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-193816
 ]

ASF GitHub Bot logged work on ARTEMIS-2226:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Feb/19 20:50
            Start Date: 03/Feb/19 20:50
    Worklog Time Spent: 10m 
      Work Description: michaelandrepearce commented on pull request #2528: 
ARTEMIS-2226 last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253318691
 
 

 ##########
 File path: 
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTConnection.java
 ##########
 @@ -216,8 +220,10 @@ public void flush() {
    public void bufferReceived(Object connectionID, ActiveMQBuffer buffer) {
    }
 
-   public void setConnected(boolean connected) {
-      this.connected = connected;
+   @Override
+   public void connected() throws Exception {
+      remotingService.sendConnectedNotification(this);
 
 Review comment:
   This should be responsibility of core system to sending notification after 
all connection behaviours are completed, so connected notification is generic. 
Eg. should be as like the current logic in plugin almost.... notifications at 
this level shouldn't be protocol specific, and like other notifications, 
they're not specific for a single protocol. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 193816)
    Time Spent: 13h 50m  (was: 13h 40m)

> (MQTT)In the cluster,the last consumer connection should close the previous 
> consumer connection
> -----------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2226
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2226
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Shiping Liang
>            Priority: Major
>          Time Spent: 13h 50m
>  Remaining Estimate: 0h
>
> Multiple consumers using the same clientId in the cluster, the last consumer 
> connection should close the previous consumer connection!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)