[ 
https://issues.apache.org/jira/browse/ARTEMIS-2226?focusedWorklogId=193821&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-193821
 ]

ASF GitHub Bot logged work on ARTEMIS-2226:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Feb/19 21:05
            Start Date: 03/Feb/19 21:05
    Worklog Time Spent: 10m 
      Work Description: michaelandrepearce commented on pull request #2528: 
ARTEMIS-2226 last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r253319407
 
 

 ##########
 File path: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
 ##########
 @@ -47,7 +47,8 @@
    SESSION_CREATED(26),
    SESSION_CLOSED(27),
    MESSAGE_DELIVERED(28),
-   MESSAGE_EXPIRED(29);
+   MESSAGE_EXPIRED(29),
+   CONNECTION_CONNECTED(30);
 
 Review comment:
   Going through and running this, and running with notification plugin, i 
notice every time this occurs, a SESSION_CREATED is also sent. 
   
   digging deeper and looking going through the logic of the connect in 
MQTTConnectionManager it seems this actually connected in the 
MQTTConnectionManager maps over to CORE as a server session (e.g. connect in 
mqtt protocol parlance == in core create a serversession), which means we 
already get a SESSION_CREATED notification with that plugin, so is it actually 
we want to ensure SESSION_CREATED notificaions are not reliant on plugin, e.g. 
bring that in... 
   
   populating.
   session.getRemotingConnection().getClientID()
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 193821)
    Time Spent: 14h 40m  (was: 14.5h)

> (MQTT)In the cluster,the last consumer connection should close the previous 
> consumer connection
> -----------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2226
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2226
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Shiping Liang
>            Priority: Major
>          Time Spent: 14h 40m
>  Remaining Estimate: 0h
>
> Multiple consumers using the same clientId in the cluster, the last consumer 
> connection should close the previous consumer connection!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to