[
https://issues.apache.org/jira/browse/ARTEMIS-2399?focusedWorklogId=267294&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-267294
]
ASF GitHub Bot logged work on ARTEMIS-2399:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jun/19 06:25
Start Date: 26/Jun/19 06:25
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #2730: ARTEMIS-2399
Fix performance degradation when there are a lot of subscribers
URL: https://github.com/apache/activemq-artemis/pull/2730#discussion_r297500166
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/Page.java
##########
@@ -312,6 +451,10 @@ public void close() throws Exception {
* While reading the cache we don't need (and shouldn't inform the backup
*/
public synchronized void close(boolean sendEvent) throws Exception {
+ if (readFileBuffer != null) {
+ fileFactory.releaseBuffer(readFileBuffer);
Review comment:
Currently the NIO pool is thread local, so I'm not sure is a good idea to do
this on different threads (very likely).
We could implement a non-thread local pool or (better), do not use the pool
but directly direct ByteBuffer instances obtained from the factory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 267294)
Time Spent: 3.5h (was: 3h 20m)
> Fix performance degradation when there are a lot of subscribers
> ---------------------------------------------------------------
>
> Key: ARTEMIS-2399
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2399
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.9.0
> Environment: broker 2.9.0
> cpu: 4 cores, memory: 8G, disk: ssd 500G
> broker.xml:
> <thread-pool-max-size>60</thread-pool-max-size>
> <address-setting match="#">
> <max-size-bytes>51Mb</max-size-bytes>
> <page-size-bytes>50Mb</page-size-bytes>
> <page-max-cache-size>1</page-max-cache-size>
> <address-full-policy>PAGE</address-full-policy>
> </address-setting>
> <message-expiry-scan-period>-1</message-expiry-scan-period>
> Reporter: yangwei
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> We noticed that there was a significant drop in performance when entering
> page mode in the case of multiple subscribers.
> We created a topic and 100 queues bound to it. We ran our _GrinderRunner
> test_ in our inner test infra cluster with 500 threads producing message and
> 560 threads, each one picked a random queue to subscribe. The test showed
> performance is bad: 13000 msg/s sent and 5000 msg/s received.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
