[
https://issues.apache.org/jira/browse/AMQNET-589?focusedWorklogId=276960&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-276960
]
ASF GitHub Bot logged work on AMQNET-589:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/19 20:17
Start Date: 15/Jul/19 20:17
Worklog Time Spent: 10m
Work Description: cjwmorgan-sol commented on issue #4: AMQNET-589:
Failover implementation
URL: https://github.com/apache/activemq-nms-amqp/pull/4#issuecomment-511553333
As far as I can tell the broker is not breaking spec as the only outcome a
broker MUST implement is Accepted. Links negotiate the Supported outcomes as a
part of link establishment.
The only requirement for modified outcome support seems come from qpid jms
implementation as that appears to be how qpid broker handle an expired message
over the wire, which is not a standard. I tried to find something to indicate a
standard way of handling expired from jms over amqp but I could not find
anything as its not in the [amqp to jms binding
doc](https://www.oasis-open.org/committees/download.php/60574/amqp-bindmap-jms-v1.0-wd09.pdf).
Handling the outcome of the for expired messages seems to be somewhat
configurable (RedeliveryPolicy, etc) in the qpid jms client. The brokers: qpid
broker, activemq5 and artemis, are likely to have consistent concepts for
message expiry and match the qpid client's default behaviour.
To have the amqp provider be a little more robust (and like the qpid jms
client) it might be worth while thinking about a future enhancement to give a
little more control to the application.
Based on what I've found I do not think this PR should be blocked by a
future enhancement. So I think the current behaviour is fine.
Is there a plan to support an IRedeliveryPolicy? I noticed some ToDos for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 276960)
Time Spent: 8.5h (was: 8h 20m)
> NMS AMQP Failover implementation
> --------------------------------
>
> Key: AMQNET-589
> URL: https://issues.apache.org/jira/browse/AMQNET-589
> Project: ActiveMQ .Net
> Issue Type: Improvement
> Components: ActiveMQ, AMQP, NMS
> Affects Versions: 1.8.0
> Reporter: Krzysztof Porebski
> Priority: Major
> Time Spent: 8.5h
> Remaining Estimate: 0h
>
> Implement failover in NMS AMQP the same way as it is implemented in QpidJMS.
> This will involve some major rework, as current design is too rigid to
> introduce this feature.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
