[ 
https://issues.apache.org/jira/browse/AMQNET-589?focusedWorklogId=277295&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-277295
 ]

ASF GitHub Bot logged work on AMQNET-589:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Jul/19 07:47
            Start Date: 16/Jul/19 07:47
    Worklog Time Spent: 10m 
      Work Description: michaelpearce-gain commented on pull request #4: 
AMQNET-589: Failover implementation
URL: https://github.com/apache/activemq-nms-amqp/pull/4#discussion_r303768515
 
 

 ##########
 File path: src/NMS.AMQP/Transport/TransportContext.cs
 ##########
 @@ -41,6 +41,49 @@ internal TransportContext()
             connectionBuilder.SASL.Profile = Amqp.Sasl.SaslProfile.Anonymous;
         }
 
+        static TransportContext()
+        {
+            //
+            // Set up tracing in AMQP.  We capture all AMQP traces in the 
TraceListener below
+            // and map to NMS 'Tracer' logs as follows:
+            //    AMQP          Tracer
+            //    Verbose       Debug
+            //    Frame         Debug
+            //    Information   Info
+            //    Output        Info    (should not happen)
+            //    Warning       Warn
+            //    Error         Error
+            //
+            Amqp.Trace.TraceLevel = Amqp.TraceLevel.Verbose | 
Amqp.TraceLevel.Frame;
+            Amqp.Trace.TraceListener = (level, format, args) =>
+            {
+                switch (level)
+                {
+                    case Amqp.TraceLevel.Verbose:
+                    case Amqp.TraceLevel.Frame:
+                        Tracer.DebugFormat(format, args);
+                        break;
+                    case Amqp.TraceLevel.Information:
+                    case Amqp.TraceLevel.Output:
+                        // 
+                        // Applications should not access AmqpLite directly so 
there
+                        // should be no 'Output' level logs.
+                        Tracer.InfoFormat(format, args);
+                        break;
+                    case Amqp.TraceLevel.Warning:
+                        Tracer.WarnFormat(format, args);
+                        break;
+                    case Amqp.TraceLevel.Error:
+                        Tracer.ErrorFormat(format, args);
+                        break;
+                    default:
 
 Review comment:
   @HavretGC  What about AMQP level, that is meant to log to trace level?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 277295)
    Time Spent: 9.5h  (was: 9h 20m)

> NMS AMQP Failover implementation
> --------------------------------
>
>                 Key: AMQNET-589
>                 URL: https://issues.apache.org/jira/browse/AMQNET-589
>             Project: ActiveMQ .Net
>          Issue Type: Improvement
>          Components: ActiveMQ, AMQP, NMS
>    Affects Versions: 1.8.0
>            Reporter: Krzysztof Porebski
>            Priority: Major
>          Time Spent: 9.5h
>  Remaining Estimate: 0h
>
> Implement failover in NMS AMQP the same way as it is implemented in QpidJMS. 
> This will involve some major rework, as current design is too rigid to 
> introduce this feature. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to