[
https://issues.apache.org/jira/browse/ARTEMIS-3113?focusedWorklogId=550819&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-550819
]
ASF GitHub Bot logged work on ARTEMIS-3113:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Feb/21 18:03
Start Date: 10/Feb/21 18:03
Worklog Time Spent: 10m
Work Description: tabish121 commented on a change in pull request #3448:
URL: https://github.com/apache/activemq-artemis/pull/3448#discussion_r573953735
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/AMQPMessageSupport.java
##########
@@ -396,7 +364,8 @@ private static CoreMessage newMessage(long id, byte
messageType, CoreMessageObje
}
- public static byte destinationType(Destination destination) {
+ // IMPORTANT-TODO: HOW TO GET THIS?
Review comment:
I'm confused, if this is important than why commit the change before
having figured that bit out, if it isn't then why leave this whole bit of
commented out code here ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 550819)
Time Spent: 0.5h (was: 20m)
> Artemis AMQP shouldn't depend on JMS
> ------------------------------------
>
> Key: ARTEMIS-3113
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3113
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.16.0
> Reporter: Emmanuel Hugonnet
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The converters between core messages and amqp messages depend on JMS. Since
> this is just for convenience we should remove this dependecy on an API that
> is being replaced.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
