[
https://issues.apache.org/jira/browse/ARTEMIS-3113?focusedWorklogId=550869&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-550869
]
ASF GitHub Bot logged work on ARTEMIS-3113:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Feb/21 19:27
Start Date: 10/Feb/21 19:27
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on a change in pull
request #3448:
URL: https://github.com/apache/activemq-artemis/pull/3448#discussion_r574013249
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/converter/jms/ServerJMSMapMessage.java
##########
@@ -137,84 +123,75 @@ public void setObject(final String name, final Object
value) throws JMSException
}
TypedProperties.setObjectProperty(new SimpleString(name), val, map);
} catch (ActiveMQPropertyConversionException e) {
- throw new MessageFormatException(e.getMessage());
+ throw new RuntimeException(e.getMessage());
}
}
- @Override
- public boolean getBoolean(final String name) throws JMSException {
+ public boolean getBoolean(final String name) throws Exception {
try {
return map.getBooleanProperty(new SimpleString(name));
} catch (ActiveMQPropertyConversionException e) {
- throw new MessageFormatException(e.getMessage());
+ throw new RuntimeException(e.getMessage());
}
}
- @Override
- public byte getByte(final String name) throws JMSException {
+ public byte getByte(final String name) throws Exception {
try {
return map.getByteProperty(new SimpleString(name));
} catch (ActiveMQPropertyConversionException e) {
- throw new MessageFormatException(e.getMessage());
+ throw new RuntimeException(e.getMessage());
Review comment:
-1 just throwing a runtime exception. This loses all context about the
exception type. Ditto this on all same in this pr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 550869)
Time Spent: 2h 10m (was: 2h)
> Artemis AMQP shouldn't depend on JMS
> ------------------------------------
>
> Key: ARTEMIS-3113
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3113
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.16.0
> Reporter: Emmanuel Hugonnet
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> The converters between core messages and amqp messages depend on JMS. Since
> this is just for convenience we should remove this dependecy on an API that
> is being replaced.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
