[
https://issues.apache.org/jira/browse/ARTEMIS-3464?focusedWorklogId=648749&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648749
]
ASF GitHub Bot logged work on ARTEMIS-3464:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/21 17:11
Start Date: 09/Sep/21 17:11
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3728:
URL: https://github.com/apache/activemq-artemis/pull/3728#discussion_r705540212
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerTarget.java
##########
@@ -380,10 +394,7 @@ private void performAck(String nodeID, long messageID,
Queue targetQueue, ACKMes
logger.warn(e.getMessage(), e);
}
} else {
- if (logger.isDebugEnabled()) {
- logger.debug("Post ack Server " + server + " could not find
messageID = " + messageID +
- " representing nodeID=" + nodeID);
- }
+ performAckOnPage(nodeID, messageID, targetQueue, ackMessageOperation);
Review comment:
this is using the same thread that would been used on the page reading
process (the scan is doing that).
in most of the cases the message should been on the queue by the depage
process. in case things are out of balance, the scan will read on the paging...
using the same thread that would been used on reading from page. it will then
issue the pageACK. I don't think you could get messages orphaned on this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 648749)
Time Spent: 50m (was: 40m)
> Mirror could Miss Acks with Paging
> ----------------------------------
>
> Key: ARTEMIS-3464
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3464
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 2.18.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.19.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The Mirror target could miss acks in some cases with Paging.
> We should add a scan for when the message couldn't be reached within depaged
> messages.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
