[
https://issues.apache.org/jira/browse/ARTEMIS-3464?focusedWorklogId=648751&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648751
]
ASF GitHub Bot logged work on ARTEMIS-3464:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/21 17:13
Start Date: 09/Sep/21 17:13
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3728:
URL: https://github.com/apache/activemq-artemis/pull/3728#discussion_r705541226
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerTarget.java
##########
@@ -476,4 +487,48 @@ public void postAcknowledge(MessageReference ref,
AckReason reason) {
public void sendMessage(Message message, RoutingContext context,
List<MessageReference> refs) {
}
+ // I need a supress warning annotation here
+ // because errorProne is issuing an error her, however I really intend to
compare PageACK against PagedReference
+ @SuppressWarnings("ComparableType")
Review comment:
I thought it was nice to use Comparable.. which was what I wanted.. I
didn't anticipate the warnings...
I will move to IntFunction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 648751)
Time Spent: 1h 10m (was: 1h)
> Mirror could Miss Acks with Paging
> ----------------------------------
>
> Key: ARTEMIS-3464
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3464
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 2.18.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.19.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The Mirror target could miss acks in some cases with Paging.
> We should add a scan for when the message couldn't be reached within depaged
> messages.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
