[
https://issues.apache.org/jira/browse/ARTEMIS-3523?focusedWorklogId=668066&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668066
]
ASF GitHub Bot logged work on ARTEMIS-3523:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Oct/21 02:37
Start Date: 21/Oct/21 02:37
Worklog Time Spent: 10m
Work Description: nbrendah commented on a change in pull request #3801:
URL: https://github.com/apache/activemq-artemis/pull/3801#discussion_r733273289
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/AddressControlImpl.java
##########
@@ -574,6 +574,11 @@ public long purge() throws Exception {
return totalMsgs;
}
+ @Override
+ public void replay() throws Exception {
Review comment:
Thanks @clebertsuconic
> I think you the signature should be the same one on ServerControl minus
the address...
`server.replay(null, null, this.getAddress(), null, null);`
In my thinking, referencing the `this is trivial.` This is what i mean,
```
public void replay(String address, String target, String filter) throws
Exception {
server.replay(null, null, this.address, target, filter);
}
```
Or i should just ignore the `this`, for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 668066)
Time Spent: 1h 40m (was: 1.5h)
> Expose replay through AddressControl
> ------------------------------------
>
> Key: ARTEMIS-3523
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3523
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Clebert Suconic
> Priority: Major
> Labels: easy
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Currently there is a method replay on ActiveMQServer with the following
> signature:
> replay(address, .....)
> it should be a lot easier for our users to implement a method replay on the
> ActiveMQServerControl
> such method should just call server.replay(this.address, .....)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
