[
https://issues.apache.org/jira/browse/ARTEMIS-3523?focusedWorklogId=668082&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668082
]
ASF GitHub Bot logged work on ARTEMIS-3523:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Oct/21 04:11
Start Date: 21/Oct/21 04:11
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3801:
URL: https://github.com/apache/activemq-artemis/pull/3801#discussion_r733303390
##########
File path:
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java
##########
@@ -230,4 +230,15 @@ String sendMessage(@Parameter(name = "headers", desc =
"The headers to add to th
@Operation(desc = "Purges the queues bound to this address. Returns the
total number of messages purged.", impact = MBeanOperationInfo.ACTION)
long purge() throws Exception;
+ @Operation(desc = "Makes the broker to read messages from the retention
folder matching the address and filter.", impact = MBeanOperationInfo.ACTION)
+ void replay(@Parameter(name = "address", desc = "Name of the address to
replay") String address,
Review comment:
the address should not be a parameter on the AddressControl...
That's the purpose, you understand? you delegate the replay from
AddressControl calling ActiveMQServer
that way you pass in (target, filter) on the AddressControl,
and the implementation will call Server.replay(this.address, target, filter);
This would make it simpler, because you are usually browsing messages at the
address level on the console. it would make it simpler for users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 668082)
Time Spent: 3h (was: 2h 50m)
> Expose replay through AddressControl
> ------------------------------------
>
> Key: ARTEMIS-3523
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3523
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Clebert Suconic
> Priority: Major
> Labels: easy
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Currently there is a method replay on ActiveMQServer with the following
> signature:
> replay(address, .....)
> it should be a lot easier for our users to implement a method replay on the
> ActiveMQServerControl
> such method should just call server.replay(this.address, .....)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
