[
https://issues.apache.org/jira/browse/ARTEMIS-3523?focusedWorklogId=668463&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-668463
]
ASF GitHub Bot logged work on ARTEMIS-3523:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Oct/21 14:30
Start Date: 21/Oct/21 14:30
Worklog Time Spent: 10m
Work Description: nbrendah commented on a change in pull request #3801:
URL: https://github.com/apache/activemq-artemis/pull/3801#discussion_r733743150
##########
File path:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/AddressControlUsingCoreTest.java
##########
@@ -178,6 +178,16 @@ public long purge() throws Exception {
return (long) proxy.invokeOperation("purge");
}
+ @Override
+ public void replay(String startScan, String endScan, String target,
String filter) throws Exception {
+ proxy.invokeOperation("replay");
Review comment:
Hey @clebertsuconic
I guess the method `proxy.invokeOperation` calls
AddressControl.replay(.....) so there is no need of passing the
`this.getAddress()` as an argument
ie
```
@Override
public void replay(String target, String filter) throws Exception {
proxy.invokeOperation("replay", this.getAddress(), target, filter);
}
```
Am sorry, it seams am taking too much time on the would be simplest issues
I am just not familiar with this code base. Am sure with some few days, my
speed will boost.
Thanks once again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 668463)
Time Spent: 4h 40m (was: 4.5h)
> Expose replay through AddressControl
> ------------------------------------
>
> Key: ARTEMIS-3523
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3523
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Clebert Suconic
> Priority: Major
> Labels: easy
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> Currently there is a method replay on ActiveMQServer with the following
> signature:
> replay(address, .....)
> it should be a lot easier for our users to implement a method replay on the
> ActiveMQServerControl
> such method should just call server.replay(this.address, .....)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
