[
https://issues.apache.org/jira/browse/ARTEMIS-3573?focusedWorklogId=685173&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-685173
]
ASF GitHub Bot logged work on ARTEMIS-3573:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/21 10:27
Start Date: 23/Nov/21 10:27
Worklog Time Spent: 10m
Work Description: brusdev commented on a change in pull request #3851:
URL: https://github.com/apache/activemq-artemis/pull/3851#discussion_r754982255
##########
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/SecureHashProcessor.java
##########
@@ -33,6 +33,6 @@ public String hash(String plainText) throws Exception {
//storedValue must take form of ENC(...)
public boolean compare(char[] inputValue, String storedValue) {
String storedHash = storedValue.substring(4, storedValue.length() - 1);
- return codec.verify(inputValue, storedHash);
+ return codec.compare(inputValue, storedHash);
Review comment:
Fair enough, I'll move this PR back to draft and I'll revisit
DefaultSensitiveStringCodec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 685173)
Time Spent: 3h 40m (was: 3.5h)
> Support PropertiesLoginModule custom password codecs
> ----------------------------------------------------
>
> Key: ARTEMIS-3573
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3573
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Domenico Francesco Bruscino
> Assignee: Domenico Francesco Bruscino
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> The `PropertiesLoginModule` login module supports only the
> `DefaultSensitiveStringCodec` codec to verify the user passwords.
> Add a property to set a custom password codec, i.e.
> org.apache.activemq.jaas.properties.password.codec="org.apache.activemq.artemis.tests.integration.security.MD5SensitiveDataCodec"
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
